linux-kernel - Re: [PATCH] msdos: add support for large disks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B9430B6.701@zytor.com>
Date:	Sun, 07 Mar 2010 15:03:18 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Daniel Taylor <Daniel.Taylor@....com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] msdos: add support for large disks

On 03/07/2010 02:59 AM, OGAWA Hirofumi wrote:
> This part is broken. If "size" is smaller than minimum blocksize (note,
> "size" is number of 512b, not number of blocksize), we can't read any
> block after all (it is handled as outside of i_size by bdev).
>
> Peter (or someone) know what do we want to in here? This is on extended
 > partition itself (e.g. if sda1 sda2<sda5 sda6>, it's the size of sda2)

We should presumably set it to one logical sector, regardless of size. 
Either that, or the offset of the lowest contained partition.

> [BTW, it seems subtypes stuff is not thinking about sector size>  512b...]

Much else isn't, either.  With the exception of some MO disks, it was 
nearly unheard of for 20 years.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/