linux-kernel - RE: [GIT PULL] MFD update for 2.6.34

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BD79186B4FD85F4B8E60E381CAEE1909022426DC@mi8nycmail19.Mi8.com>
Date:	Mon, 8 Mar 2010 10:20:04 -0500
From:	"H Hartley Sweeten" <hartleys@...ionengravers.com>
To:	"Paul Mundt" <lethal@...ux-sh.org>,
	"Samuel Ortiz" <sameo@...ux.intel.com>
Cc:	"Linus Torvalds" <torvalds@...ux-foundation.org>,
	"linux-kernel" <linux-kernel@...r.kernel.org>,
	"Peter Huewe" <peterhuewe@....de>,
	"Randy Dunlap" <randy.dunlap@...cle.com>,
	"Denis Turischev" <denis@...pulab.co.il>,
	"Mark Brown" <broonie@...nsource.wolfsonmicro.com>,
	"Mike Turquette" <mturquette@...com>,
	"Magnus Damm" <damm@...nsource.se>,
	"Yusuke Goda" <goda.yusuke@...esas.com>,
	"Guennadi Liakhovetski" <g.liakhovetski@....de>,
	"Balaji T K" <balajitk@...com>,
	"Moiz Sonasath" <m-sonasath@...com>,
	"Eduardo Valentin" <eduardo.valentin@...ia.com>,
	"Haojian Zhuang" <haojian.zhuang@...vell.com>,
	"Joonyoung Shim" <jy0922.shim@...sung.com>,
	"Christoph Egger" <siccegge@...d.informatik.uni-erlangen.de>,
	"Linus Walleij" <linus.walleij@...ricsson.com>,
	"Cory Maccarrone" <darkstar6262@...il.com>,
	"Julia Lawall" <julia@...u.dk>
Subject: RE: [GIT PULL] MFD update for 2.6.34

On Monday, March 08, 2010 4:49 AM, Paul Mundt wrote:
> On Sun, Mar 07, 2010 at 10:53:25PM +0100, Samuel Ortiz wrote:
>> H Hartley Sweeten (3):
>>       mfd: Use resource_size() in sm501
>>       mfd: Use resource_size() for t7l66xb
>>       mfd: Use resouce_size for tc6393xb
>> 
> These need to be looked at carefully, at least the sm501 change is
> totally bogus, breaks everything, and stems from a total lack of
> understanding of how the drivers interact.
>
> The I/O resource that's remapped and handled by the MFD takes the full
> size, while the region request is purposely trimmed down so only the
> registers needed by the MFD driver are reserved by the MFD driver. Other
> drivers (like sm501fb) will have their own region requests within the
> same resource at different offsets, all of which are broken after this
> change.
>
> As such, 311e54c07e784fe63d421f724dcc597d1f82ccad at least needs to be
> reverted. I haven't looked at the other two, but if it's a similar
> mechanical change then those should be dropped, too.

Hello Paul,

I took a look at the sm501 patch and see your concern.

The ioremap change to use resource_size looks ok. But the two request_mem_region
changes are an issue due to the point you mentioned above.

The patches to t7166xb and tc6393xb both appear to be ok. They do not have the
same issue.

Regards,
Hartley
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/