linux-kernel - Re: [GIT PULL] MFD update for 2.6.34

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100308114835.GA16081@linux-sh.org>
Date:	Mon, 8 Mar 2010 20:48:36 +0900
From:	Paul Mundt <lethal@...ux-sh.org>
To:	Samuel Ortiz <sameo@...ux.intel.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Peter Huewe <peterhuewe@....de>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Denis Turischev <denis@...pulab.co.il>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Mike Turquette <mturquette@...com>,
	Magnus Damm <damm@...nsource.se>,
	Yusuke Goda <goda.yusuke@...esas.com>,
	Guennadi Liakhovetski <g.liakhovetski@....de>,
	Balaji T K <balajitk@...com>,
	Moiz Sonasath <m-sonasath@...com>,
	Eduardo Valentin <eduardo.valentin@...ia.com>,
	Haojian Zhuang <haojian.zhuang@...vell.com>,
	Joonyoung Shim <jy0922.shim@...sung.com>,
	Christoph Egger <siccegge@...d.informatik.uni-erlangen.de>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	Cory Maccarrone <darkstar6262@...il.com>,
	Julia Lawall <julia@...u.dk>,
	H Hartley Sweeten <hartleys@...ionengravers.com>
Subject: Re: [GIT PULL] MFD update for 2.6.34

On Sun, Mar 07, 2010 at 10:53:25PM +0100, Samuel Ortiz wrote:
> H Hartley Sweeten (3):
>       mfd: Use resource_size() in sm501
>       mfd: Use resource_size() for t7l66xb
>       mfd: Use resouce_size for tc6393xb
> 
These need to be looked at carefully, at least the sm501 change is
totally bogus, breaks everything, and stems from a total lack of
understanding of how the drivers interact.

The I/O resource that's remapped and handled by the MFD takes the full
size, while the region request is purposely trimmed down so only the
registers needed by the MFD driver are reserved by the MFD driver. Other
drivers (like sm501fb) will have their own region requests within the
same resource at different offsets, all of which are broken after this
change.

As such, 311e54c07e784fe63d421f724dcc597d1f82ccad at least needs to be
reverted. I haven't looked at the other two, but if it's a similar
mechanical change then those should be dropped, too.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/