[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5A47E75E594F054BAF48C5E4FC4B92AB0321623721@dbde02.ent.ti.com>
Date: Mon, 8 Mar 2010 22:01:45 +0530
From: "Gadiyar, Anand" <gadiyar@...com>
To: Mike Frysinger <vapier@...too.org>,
"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
Felipe Balbi <felipe.balbi@...ia.com>
CC: "stable@...nel.org" <stable@...nel.org>,
"stable-review@...nel.org" <stable-review@...nel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Sonic Zhang <sonic.zhang@...log.com>
Subject: RE: [PATCH] USB: musb: fix build error introduced by isoc change
Mike Frysinger wrote:
>
> From: Sonic Zhang <sonic.zhang@...log.com>
>
> The recent commit "usb: musb: Fix for isochronous IN transfer" (f82a689fa)
> seems to have been against an older kernel version. It uses the old style
> naming of variables. Unfortunately, this breaks building for most MUSB
> users out there since "bDesiredMode" has been renamed to "desired_mode".
>
Looks like this code is under a "#ifdef USE_MODE1" check; that's why
we did not find this during regular builds. Felipe's upcoming patches
would make this code redundant anyway.
Till then, we might as well fix it.
> Signed-off-by: Sonic Zhang <sonic.zhang@...log.com>
> Signed-off-by: Mike Frysinger <vapier@...too.org>
Acked-by: Anand Gadiyar <gadiyar@...com>
> ---
> drivers/usb/musb/musb_host.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
> index d21fffa..ef29f38 100644
> --- a/drivers/usb/musb/musb_host.c
> +++ b/drivers/usb/musb/musb_host.c
> @@ -1689,7 +1689,7 @@ void musb_host_rx(struct musb *musb, u8 epnum)
> dma->desired_mode = 1;
> if (rx_count < hw_ep->max_packet_sz_rx) {
> length = rx_count;
> - dma->bDesiredMode = 0;
> + dma->desired_mode = 0;
> } else {
> length = urb->transfer_buffer_length;
> }
> --
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists