lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 8 Mar 2010 11:41:26 -0500
From:	Mike Frysinger <vapier.adi@...il.com>
To:	"Gadiyar, Anand" <gadiyar@...com>
Cc:	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	Felipe Balbi <felipe.balbi@...ia.com>,
	"stable@...nel.org" <stable@...nel.org>,
	"stable-review@...nel.org" <stable-review@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Sonic Zhang <sonic.zhang@...log.com>
Subject: Re: [PATCH] USB: musb: fix build error introduced by isoc change

On Mon, Mar 8, 2010 at 11:31, Gadiyar, Anand wrote:
> Mike Frysinger wrote:
>> From: Sonic Zhang <sonic.zhang@...log.com>
>>
>> The recent commit "usb: musb: Fix for isochronous IN transfer" (f82a689fa)
>> seems to have been against an older kernel version.  It uses the old style
>> naming of variables.  Unfortunately, this breaks building for most MUSB
>> users out there since "bDesiredMode" has been renamed to "desired_mode".
>>
>
> Looks like this code is under a "#ifdef USE_MODE1" check; that's why
> we did not find this during regular builds.

ah, ok.  Felipe should tweak the changelog to mention this when merging ;)

> Felipe's upcoming patches would make this code redundant anyway.
>
> Till then, we might as well fix it.

right ... this at least should go into 2.6.33.x
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ