linux-kernel - Re: [PATCH] USB: musb: fix build error introduced by isoc change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100308183453.GF6630@gandalf>
Date:	Mon, 8 Mar 2010 20:34:54 +0200
From:	Felipe Balbi <me@...ipebalbi.com>
To:	"Gadiyar, Anand" <gadiyar@...com>
Cc:	Mike Frysinger <vapier@...too.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	Felipe Balbi <felipe.balbi@...ia.com>,
	"stable@...nel.org" <stable@...nel.org>,
	"stable-review@...nel.org" <stable-review@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Sonic Zhang <sonic.zhang@...log.com>
Subject: Re: [PATCH] USB: musb: fix build error introduced by isoc change

On Mon, Mar 08, 2010 at 10:01:45PM +0530, Gadiyar, Anand wrote:
> Mike Frysinger wrote:
> > 
> > From: Sonic Zhang <sonic.zhang@...log.com>
> > 
> > The recent commit "usb: musb: Fix for isochronous IN transfer" (f82a689fa)
> > seems to have been against an older kernel version.  It uses the old style
> > naming of variables.  Unfortunately, this breaks building for most MUSB
> > users out there since "bDesiredMode" has been renamed to "desired_mode".
> > 
> 
> Looks like this code is under a "#ifdef USE_MODE1" check; that's why
> we did not find this during regular builds. Felipe's upcoming patches
> would make this code redundant anyway.
> 
> Till then, we might as well fix it.

yes, it was my bad. I should have reviewed the code more carefully. We
will be testing the mode1 support on DaVinci during this and the next
week and when we get it working, we will publish the mode1 dma changes
again which will completely change this code.

> > Signed-off-by: Sonic Zhang <sonic.zhang@...log.com>
> > Signed-off-by: Mike Frysinger <vapier@...too.org>
> 
> Acked-by: Anand Gadiyar <gadiyar@...com>

Acked-by: Felipe Balbi <felipe.balbi@...ia.com>

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/