lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 10 Mar 2010 11:15:58 -0800 From: ebiederm@...ssion.com (Eric W. Biederman) To: Yinghai Lu <yinghai@...nel.org> Cc: Ian Campbell <Ian.Campbell@...rix.com>, "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>, Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>, "H. Peter Anvin" <hpa@...or.com>, Jeremy Fitzhardinge <jeremy@...p.org>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, Paul Mackerras <paulus@...ba.org>, "x86\@kernel.org" <x86@...nel.org>, "linuxppc-dev\@ozlabs.org" <linuxppc-dev@...abs.org> Subject: Re: [PATCH] irq: move some interrupt arch_* functions into struct irq_chip. Yinghai Lu <yinghai@...nel.org> writes: > On 03/10/2010 04:51 AM, Ian Campbell wrote: >> On Wed, 2010-03-10 at 12:06 +0000, Yinghai Lu wrote: >>> On Wed, Mar 10, 2010 at 2:55 AM, <ijc@...lion.org.uk> wrote: >>>> From: Ian Campbell <ian.campbell@...rix.com> >>>> >>>> Move arch_init_copy_chip_data and arch_free_chip_data into function >>>> pointers in struct irq_chip since they operate on irq_desc->chip_data. >>>> >>>> arch_init_chip_data cannot be moved into struct irq_chip at this time >>>> because irq_desc->chip is not known at the time the irq_desc is >>>> setup. For now rename arch_init_chip_data to arch_init_irq_desc (for >>>> PowerPC, the only other user, whose usage better matches the new name) >>>> and on x86 convert arch_init_chip_data to ioapic_init_chip_data and >>>> call this whenever the IO APIC code allocates a new IRQ. >>>> >>>> I've retained the chip_data behaviour for uv_irq although it isn't >>>> clear to me if these interrupt types support migration or how closely >>>> related to the APIC modes they really are. If it weren't for this the >>>> ioapic_{init,copy,free}_chip_data functions could be static to >>>> io_apic.c. >>>> >>>> I've tested by booting on a 64 bit system, but it's not clear to me >>>> what actions I need to take to actually exercise some of these code >>>> paths. >>>> >>> >>> can you just add another pointer field in irq_desc? >>> >>> some kind of *irq_info etc. >> >> I think I don't understand what you are suggesting. >> >> There is already a pointer for irq_chip specific use i.e. >> irq_desc->chip_data. This patchset is just about ensuring that the field >> really is available to any chip implementation rather than just assuming >> it is always used for the acpi chip types (on x86 at least). >> >> Does adding a second pointer with the same (intended?) semantics as the >> existing one buy us anything? > > > #ifdef CONFIG_INTR_REMAP > struct irq_2_iommu *irq_2_iommu; > #endif > struct irq_chip *chip; > struct msi_desc *msi_desc; > > we already have that for irq_2_iommu and msi_desc Those are at different levels of the hierarchy. Adding another pointer for Xen is like having a different iommu and so adding another pointer to handle that kind of iommu. Eric -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists