linux-kernel - Re: [PATCH 2/3] input: use input_mutex instead of BKL when opening input device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201003100749.20723.oliver@neukum.org>
Date:	Wed, 10 Mar 2010 07:49:20 +0100
From:	Oliver Neukum <oliver@...kum.org>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com>,
	Arnd Bergmann <arnd@...db.de>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org, John Kacur <jkacur@...il.com>,
	jkosina@...e.cz
Subject: Re: [PATCH 2/3] input: use input_mutex instead of BKL when opening input device

Am Mittwoch, 10. März 2010 07:20:15 schrieb Dmitry Torokhov:
> > I was willing to let the open call go unprotected. But ended up checking
> > that the three callees were fine (they do not call any of the other
> > functions that take the mutex).
> > 
> > Since the fops_put/fops_get do protect that section from the handler
> > removal and I can't think of any other race right now, I think your
> > version is really better.
> > 
> > Acked-by: Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com>
> > 
> 
> OK, applied 2 Thadeu's patches and one Arnd's.

Jiri,

it is possible that this requires a change in usbhid as it uses BKL.
Do you remember?

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/