linux-kernel - Re: [PATCH 05/11] ST SPEAr: Added clock framework for SPEAr platform and machines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100311102845.GA16376@n2100.arm.linux.org.uk>
Date:	Thu, 11 Mar 2010 10:28:45 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Viresh KUMAR <viresh.kumar@...com>
Cc:	linux-arm-kernel@...ts.infradead.org, rajeev-dlh.kumar@...com,
	shiraz.hashim@...com, armando.visconti@...com,
	ashish.priyadarshi@...com, linux-kernel@...r.kernel.org,
	vipin.kumar@...com, amit.goel@...com, deepak.sikri@...com
Subject: Re: [PATCH 05/11] ST SPEAr: Added clock framework for SPEAr
	platform and machines

On Wed, Mar 03, 2010 at 10:37:35AM +0530, Viresh KUMAR wrote:
> +/* array of all spear 3xx clock lookups */
> +static struct clk_lookup *spear_clk_lookups[] = {
> +	/* root clks */
> +	&osc_32k_cl,
> +	&osc_24m_cl,

This is rather wasteful - rather than defining structures, and then having
a one-time-used set of pointers to the structures, why not just declare
the whole lot as an array like most other implementations do?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/