linux-kernel - Re: [PATCH 02/11] ST SPEAr: Added basic header files for SPEAr3xx machine family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100311103321.GB16376@n2100.arm.linux.org.uk>
Date:	Thu, 11 Mar 2010 10:33:21 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Viresh KUMAR <viresh.kumar@...com>
Cc:	linux-arm-kernel@...ts.infradead.org, rajeev-dlh.kumar@...com,
	shiraz.hashim@...com, armando.visconti@...com,
	ashish.priyadarshi@...com, linux-kernel@...r.kernel.org,
	vipin.kumar@...com, amit.goel@...com, deepak.sikri@...com
Subject: Re: [PATCH 02/11] ST SPEAr: Added basic header files for SPEAr3xx
	machine family

On Wed, Mar 03, 2010 at 10:37:32AM +0530, Viresh KUMAR wrote:
> diff --git a/arch/arm/mach-spear3xx/include/mach/dma.h b/arch/arm/mach-spear3xx/include/mach/dma.h
> new file mode 100644
> index 0000000..9b93bc6
> --- /dev/null
> +++ b/arch/arm/mach-spear3xx/include/mach/dma.h
> @@ -0,0 +1,18 @@
> +/*
> + * arch/arm/mach-spear3xx/include/mach/dma.h
> + *
> + * Generic DMA support for SPEAr3xx machine family
> + *
> + * Copyright (C) 2009 ST Microelectronics
> + * Viresh Kumar<viresh.kumar@...com>
> + *
> + * This file is licensed under the terms of the GNU General Public
> + * License version 2. This program is licensed "as is" without any
> + * warranty of any kind, whether express or implied.
> + */
> +
> +#ifndef __ASM_ARCH_DMA_H
> +#define __ASM_ARCH_DMA_H
> +
> +#endif /* __ASM_ARCH_DMA_H */
> +

You don't need to provide this file if you don't use it.

> diff --git a/arch/arm/mach-spear3xx/include/mach/vmalloc.h b/arch/arm/mach-spear3xx/include/mach/vmalloc.h
> new file mode 100644
> index 0000000..4f236f3
> --- /dev/null
> +++ b/arch/arm/mach-spear3xx/include/mach/vmalloc.h
> @@ -0,0 +1,22 @@
> +/*
> + * arch/arm/mach-spear3xx/include/mach/vmalloc.h
> + *
> + * Defining Vmalloc area for SPEAr3xx machine family
> + *
> + * Copyright (C) 2009 ST Microelectronics
> + * Viresh Kumar<viresh.kumar@...com>
> + *
> + * This file is licensed under the terms of the GNU General Public
> + * License version 2. This program is licensed "as is" without any
> + * warranty of any kind, whether express or implied.
> + */
> +
> +#ifndef __ASM_MACH_VMALLOC_H
> +#define __ASM_MACH_VMALLOC_H
> +
> +#include <mach/memory.h>
> +
> +#define VMALLOC_SIZE		(0x30000000)
> +#define VMALLOC_END		(PAGE_OFFSET + VMALLOC_SIZE)

Don't define it like this - define VMALLOC_END to be the maximum virtual
address which you can permit the vmalloc area to extend to - which is
generally the start of your peripheral mappings.

It's rather pointless defining it in terms of PAGE_OFFSET, because this
can vary, whereas the start of your peripheral mappings tends to be
fixed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/