linux-kernel - Re: [PATCH] powerpc/BSR: fix device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100311212157.GD5204@us.ibm.com>
Date:	Thu, 11 Mar 2010 15:21:57 -0600
From:	Sonny Rao <sonnyrao@...ibm.com>
To:	Jani Nikula <ext-jani.1.nikula@...ia.com>
Cc:	linux-kernel@...r.kernel.org, benh@...nel.crashing.org,
	tklauser@...tanz.ch, jkosina@...e.cz
Subject: Re: [PATCH] powerpc/BSR: fix device_create() return value check

On Thu, Mar 11, 2010 at 06:15:53PM +0200, Jani Nikula wrote:
> From: Jani Nikula <ext-jani.1.nikula@...ia.com>
> 
> Use IS_ERR() instead of comparing to NULL.
> 
> Signed-off-by: Jani Nikula <ext-jani.1.nikula@...ia.com>
> 
> ---
> 
> NOTE: I'm afraid I'm unable to test this; please consider this more a
> bug report than a complete patch.
> ---
>  drivers/char/bsr.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/char/bsr.c b/drivers/char/bsr.c
> index c02db01..3b31f74 100644
> --- a/drivers/char/bsr.c
> +++ b/drivers/char/bsr.c
> @@ -252,7 +252,7 @@ static int bsr_add_node(struct device_node *bn)
> 
>  		cur->bsr_device = device_create(bsr_class, NULL, cur->bsr_dev,
>  						cur, cur->bsr_name);
> -		if (!cur->bsr_device) {
> +		if (IS_ERR(cur->bsr_device)) {
>  			printk(KERN_ERR "device_create failed for %s\n",
>  			       cur->bsr_name);
>  			cdev_del(&cur->bsr_cdev);
> -- 
> 1.6.5.2
> 

This looks fine to me, good catch.

Acked-by: Sonny Rao <sonnyrao@...ibm.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/