linux-kernel - Re: madness, was Re: [PATCH 2/2] Macintosh: fix coding style issues in adb.c This is a patch to the adb.c file that cleans up many warnings found by the checkpatch.pl tool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1268343910.22204.710.camel@pasglop>
Date:	Fri, 12 Mar 2010 08:45:10 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	fthain@...egraphics.com.au
Cc:	Michael Beardsworth <mbeards2@...egon.edu>,
	grant.likely@...retlab.ca, geert@...ux-m68k.org, monstr@...str.eu,
	Nick Savage <nagaten@...il.com>, linuxppc-dev@...abs.org,
	linux-kernel@...r.kernel.org
Subject: Re: madness, was Re: [PATCH 2/2] Macintosh: fix coding style
 issues in adb.c This is a patch to the adb.c file that cleans up many
 warnings found by the checkpatch.pl tool

On Wed, 2010-03-10 at 14:48 +1100, fthain@...egraphics.com.au wrote:
> On Tue, 9 Mar 2010, Michael Beardsworth wrote:
> 
> > -	/* If a probe is in progress or we are sleeping, wait for it to complete */
> > +	/* If a probe is in progress or we are sleeping, wait until complete */
> 
> If you must "fix" what aint broke, please try not to damage it. I'm sorry 
> if your VT52 is limited to 80 cols, but IMNSHO this sort of effort is 
> misguided.
> 
> Maybe I could point out again (I do this periodically) that checkpatch.pl 
> is great but code that fails it is NOT always wrong.
> 
> "Check patch" is a good idea but "check existing code" is a waste of 
> everyone's time.

Amen !

Cheers,
Ben.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/