linux-kernel - madness, was Re: [PATCH 2/2] Macintosh: fix coding style issues in adb.c This is a patch to the adb.c file that cleans up many warnings found by the checkpatch.pl tool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1003101428460.4583@nippy.intranet>
Date:	Wed, 10 Mar 2010 14:48:13 +1100 (EST)
From:	fthain@...egraphics.com.au
To:	Michael Beardsworth <mbeards2@...egon.edu>
cc:	benh@...nel.crashing.org, grant.likely@...retlab.ca,
	geert@...ux-m68k.org, monstr@...str.eu,
	Nick Savage <nagaten@...il.com>, linuxppc-dev@...abs.org,
	linux-kernel@...r.kernel.org
Subject: madness, was Re: [PATCH 2/2] Macintosh: fix coding style issues in
 adb.c This is a patch to the adb.c file that cleans up many warnings found
 by the checkpatch.pl tool


On Tue, 9 Mar 2010, Michael Beardsworth wrote:

> -	/* If a probe is in progress or we are sleeping, wait for it to complete */
> +	/* If a probe is in progress or we are sleeping, wait until complete */

If you must "fix" what aint broke, please try not to damage it. I'm sorry 
if your VT52 is limited to 80 cols, but IMNSHO this sort of effort is 
misguided.

Maybe I could point out again (I do this periodically) that checkpatch.pl 
is great but code that fails it is NOT always wrong.

"Check patch" is a good idea but "check existing code" is a waste of 
everyone's time.

Finn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/