linux-kernel - Re: [PATCH] err.h: add __must_check to error pointer handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100312184056.GA4107@x200>
Date:	Fri, 12 Mar 2010 20:40:56 +0200
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	Jani Nikula <ext-jani.1.nikula@...ia.com>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	ext-phil.2.carmody@...ia.com
Subject: Re: [PATCH] err.h: add __must_check to error pointer handlers

On Fri, Mar 12, 2010 at 03:45:40PM +0200, Jani Nikula wrote:
> Add __must_check to error pointer handlers to have the compiler warn
> about mistakes like:
> 
> 	if (err)
> 		ERR_PTR(err);

> -static inline void *ERR_PTR(long error)
> +static inline void * __must_check ERR_PTR(long error)

We had bugs like that?

Pretty much every non-void function should be marked then.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/