linux-kernel - Re: [PATCH] x86,perf: Unmask LVTPC only if we have APIC supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 13 Mar 2010 18:03:05 +0300
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Lin Ming <ming.m.lin@...el.com>,
	Peter Zijlstra <peterz@...radead.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86,perf: Unmask LVTPC only if we have APIC supported

On Sat, Mar 13, 2010 at 02:50:22PM +0100, Ingo Molnar wrote:
...
> > All-in-once: unresolved external symbol here, which could be fixed either by 
> > introducing dummy symbol, or conditional compilation. I think the second is 
> > preferred if the issue is just one line code.
> > 
> > Or you mean something different and I took a wrong mind-path?
> 
> Well it's not just one line of code as (like you mentioned) perf_event.c is 
> affected as well.
> 
> Introducing a dummy (NOP) placeholder method is what we are doing in all the 
> other cases (such as spin_lock()), we dont pollute the kernel with #ifdefs.
> 
> 	Ingo
> 

ok, Ingo, this will consume some time. Could you pick up the original patch
just for now (so that testing builds will not fail), I'll back to this task
tomorrow or at Monday. OK?

	-- Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/