linux-kernel - Re: [PATCH] base firmware: Fix BUG from sysfs attributes change in commit a2db6842873c8e5a70652f278d469128cb52db70

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1003131455420.3719@i5.linux-foundation.org>
Date:	Sat, 13 Mar 2010 14:57:20 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Jiri Kosina <jkosina@...e.cz>
cc:	Larry Finger <Larry.Finger@...inger.net>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	WANG Cong <xiyou.wangcong@...il.com>,
	Greg Kroah-Hartman <gregkh@...e.de>, Tejun Heo <tj@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] base firmware: Fix BUG from sysfs attributes change in
 commit a2db6842873c8e5a70652f278d469128cb52db70



On Sat, 13 Mar 2010, Jiri Kosina wrote:
> 
> Well, the special initialization shouldn't be needed for all the 68 cases 
> as far as I can see. It's needed only for dynamically allocated sysfs 
> attributes, the static ones are fine.

So does anybody have a 'grep' for it?

Because we sure as hell don't want to find them one by one, especially 
since this thing only shows up in a fairly rare configuration (most people 
do _not_ enable lockdep).

So that commit really _is_ broken. I'm seriously going to just revert it 
if the plan of action is nothing better than "wait for people to report 
yet another missed conversion". This is _not_ how we convert users.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/