linux-kernel - Re: [PATCH] base firmware: Fix BUG from sysfs attributes change in commit a2db6842873c8e5a70652f278d469128cb52db70

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m1fx43zhbd.fsf@fess.ebiederm.org>
Date:	Sat, 13 Mar 2010 19:57:10 -0800
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Jiri Kosina <jkosina@...e.cz>,
	Larry Finger <Larry.Finger@...inger.net>,
	WANG Cong <xiyou.wangcong@...il.com>,
	Greg Kroah-Hartman <gregkh@...e.de>, Tejun Heo <tj@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] base firmware: Fix BUG from sysfs attributes change in commit a2db6842873c8e5a70652f278d469128cb52db70

Linus Torvalds <torvalds@...ux-foundation.org> writes:

> On Sat, 13 Mar 2010, Jiri Kosina wrote:
>> 
>> Well, the special initialization shouldn't be needed for all the 68 cases 
>> as far as I can see. It's needed only for dynamically allocated sysfs 
>> attributes, the static ones are fine.
>
> So does anybody have a 'grep' for it?
>
> Because we sure as hell don't want to find them one by one, especially 
> since this thing only shows up in a fairly rare configuration (most people 
> do _not_ enable lockdep).

It also only affects those fairly rare lockdep users as well, and the only
affect is to throw a nasty warning message.  Isn't lockdep all about throwing
nasty warning messages?

> So that commit really _is_ broken. I'm seriously going to just revert it 
> if the plan of action is nothing better than "wait for people to report 
> yet another missed conversion". This is _not_ how we convert users.

Linus I think this can be the start of a new development tradition.
The annual birthday scolding from Linus.  I am certain we will all
appreciate the attention.

Unfortunately I have been extremely busy this last week and haven't
been able to do anything so you have only seen my backup plan in
effect where reasonable kernel developers notice the instances I
missed and on a case by case basis trivially fix it.  I believe Greg
has been queuing up many of those case by case fixes.  A few have been
flowing through other maintainers.

Wolfram Sang was figuring out if he could get coccinelle (whatever
that is) to find more of them.

It is my intention to go through all of the reports make certain everything
is getting fixed, and also to look through and see if I can find any more
cases that I have overlooked.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/