linux-kernel - Re: [PATCH] Staging: wlan-ng: fix coding style in hfa834x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4B9E03E5.70702@rsk.demon.co.uk>
Date:	Mon, 15 Mar 2010 09:54:45 +0000
From:	Richard Kennedy <richard@....demon.co.uk>
To:	ehames@...il.com
CC:	gregkh@...e.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: wlan-ng: fix coding style in hfa834x_usb.c

On 13/03/10 01:07, ehames@...il.com wrote:
> From: Edgardo Hames <ehames@...il.com>
> 
> This is a patch in hfa834x_usb.c to fix typedef declarations and long lines.
> 
> Signed-off-by: Edgardo Hames <ehames@...il.com>
> ---
Hi Edgardo,

Definitely a good thing to get rid of the typedefs.

>  			printk(KERN_ERR
> -			       "cmd_initialize() failed on two attempts, results %d and %d\n",
> -			       result1, result2);
> +				"cmd_initialize() failed on two attempts,"
> +				" results %d and %d\n", result1, result2);
>  			usb_kill_urb(&hw->rx_urb);

But I don't think you should split up the printk strings (like this one)
as it make them difficult to grep for.


> @@ -3382,8 +3382,9 @@ retry:
>  			 * our request has been acknowledged. Odd,
>  			 * but our OUT URB is still alive...
>  			 */
> -			pr_debug
> -			    ("Causality violation: please reboot Universe, or email linux-wlan-devel@...ts.linux-wlan.com\n");
> +			pr_debug("Causality violation: "
> +				 "please reboot Universe, or email "
> +				 "linux-wlan-devel@...ts.linux-wlan.com\n");
>  			ctlx->state = CTLX_RESP_COMPLETE;
>  			break;

This mailing list is dead, so there's no point in still directing people
there, so you can just drop the second half of that message.

regards
Richard

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/