linux-kernel - Re: [patch 2/3] genirq: warn about IRQF_SHARED|IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100315025249.GP6491@shareable.org>
Date:	Mon, 15 Mar 2010 02:52:49 +0000
From:	Jamie Lokier <jamie@...reable.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	u.kleine-koenig@...gutronix.de, a.p.zijlstra@...llo.nl,
	andrea.gallo@...ricsson.com, dbrownell@...rs.sourceforge.net,
	eric.y.miao@...il.com, hugh.dickins@...cali.co.uk,
	John Stultz <johnstul@...ibm.com>, linux@...mer.net,
	nico@...vell.com, Rusty Russell <rusty@...tcorp.com.au>,
	Greg KH <greg@...ah.com>, David Miller <davem@...emloft.net>
Subject: Re: [patch 2/3] genirq: warn about IRQF_SHARED|IRQF_DISABLED at the right place

Andrew Morton wrote:
> We can tweak and tune until we're blue in the face, but the system's
> IRQ latency will always be worse if handlers always run with interrupts
> disabled.

Are you sure?

If good, fast irq handler A runs with interrupts enabled,
and good, fast irq handler B runs (interrupting A),
A's latency goes _up_ not down.

If B happens first, then you get B's latency going up, and A's latency going down.

It's not really clear what happens to average latency.  But if you
know that some handlers require lower latency than others (e.g. serial
ports with small FIFOs), it makes sense to prioritise them.

-- Jamie
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/