linux-kernel - Re: pcmcia's use of IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100315174359.7fa53d4b@linux.intel.com>
Date:	Mon, 15 Mar 2010 17:43:59 +0000
From:	Alan Cox <alan@...ux.intel.com>
To:	Dominik Brodowski <linux@...inikbrodowski.net>
Cc:	Jan Beulich <JBeulich@...ell.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: pcmcia's use of IRQ_NOAUTOEN

On Mon, 8 Mar 2010 20:47:57 +0100
Dominik Brodowski <linux@...inikbrodowski.net> wrote:

> Hey,
> 
> On Mon, Mar 08, 2010 at 10:17:11AM +0000, Jan Beulich wrote:
> > (re-sending to correct Alan's email address)
> > 
> > Commit 635416ef393e8cec5a89fc6c1de710ee9596a51e introduced
> > this, but I can't see how it can take effect - the argument passed
> > to request_irq() only affects action->flags (IRQF_*), whereas the
> > flag in question is a desc->status one (IRQ_*). Am I overlooking
> > something? If not, while currently this just should not work as
> > expected, it's latently more significant (as soon as the IRQF_*
> > definitions make use of the bit used by IRQ_NOAUTOEN).
> 
> You're right, it seems to make no sense. Or less than that.
> 
> Alan, what do you think?

It should be setting the correct NOAUTOEN bits so that the IRQ isn't
randomly enabled as some hardware then crashes. How it ended up wrong
upstream I don't know as it was tested and fixed the bug, so presumably
the right version got tested or it happened to work back on the old irq
code by luck.

I don't think you are overlooking anything - there is no deep magic
involved.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/