linux-kernel - Re: pcmcia's use of IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100315181829.GA26096@isilmar.linta.de>
Date:	Mon, 15 Mar 2010 19:18:29 +0100
From:	Dominik Brodowski <linux@...inikbrodowski.net>
To:	Alan Cox <alan@...ux.intel.com>
Cc:	Jan Beulich <JBeulich@...ell.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: pcmcia's use of IRQ_NOAUTOEN

Hey,

On Mon, Mar 15, 2010 at 05:43:59PM +0000, Alan Cox wrote:
> > You're right, it seems to make no sense. Or less than that.
> > 
> > Alan, what do you think?
> 
> It should be setting the correct NOAUTOEN bits so that the IRQ isn't
> randomly enabled as some hardware then crashes. How it ended up wrong
> upstream I don't know as it was tested and fixed the bug, so presumably
> the right version got tested or it happened to work back on the old irq
> code by luck.

http://lkml.org/lkml/2007/4/5/127 and then
http://lkml.org/lkml/2007/4/26/485 talk a different language :(

> I don't think you are overlooking anything - there is no deep magic
> involved.

I'll just revert it.

Best,
	Dominik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/