linux-kernel - Re: [PATCH] kref: remove kref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100316175423.GA23303@kroah.com>
Date:	Tue, 16 Mar 2010 10:54:23 -0700
From:	Greg KH <greg@...ah.com>
To:	NeilBrown <neilb@...e.de>
Cc:	Greg KH <gregkh@...e.de>, Mimi Zohar <zohar@...ibm.com>,
	"Serge E . Hallyn" <serue@...ibm.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kref: remove kref_set

On Tue, Mar 16, 2010 at 03:14:51PM +1100, NeilBrown wrote:
> 
> 
> Of the three uses of kref_set in the kernel:
> 
>  One really should be kref_put as the code is letting go of a
>     reference,
>  Two really should be kref_init because the kref is being
>     initialised.
> 
> This suggests that making kref_set available encourages bad code.
> So fix the three uses and remove kref_set completely.

Yeah!

I really didn't like kref_set at all anyway, and I thought that someone
"required it" which is why it was added.  Oh well, I'm glad it is now
gone, thanks so much for this patch.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/