linux-kernel - Re: [PATCH 0/2] small xhci cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100316212445.GA15729@xanatos>
Date:	Tue, 16 Mar 2010 14:24:45 -0700
From:	Sarah Sharp <sarah.a.sharp@...ux.intel.com>
To:	Greg KH <greg@...ah.com>, Alex Chiang <achiang@...com>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] small xhci cleanups

On Tue, Mar 09, 2010 at 10:47:23AM -0800, Greg KH wrote:
> On Tue, Mar 09, 2010 at 11:32:27AM -0700, Alex Chiang wrote:
> > * Greg KH <greg@...ah.com>:
> > > On Tue, Mar 09, 2010 at 10:52:43AM -0700, Alex Chiang wrote:
> > > 
> > > >       USB: xhci: move all debug code under CONFIG_XHCI_HCD_DEBUGGING
> > > 
> > > Does this conflict with Sarah's other debugging patch she just sent out?
> > 
> > I'm assuming you're talking about this patch:
> > 
> > 	http://thread.gmane.org/gmane.linux.usb.general/28681
> 
> Yes.
> 
> > Yes, we'll definitely have conflicts. If you agree that we should
> > move the debug code under the Kconfig option, then the best
> > course of action would be for Sarah to rebase her work on top of
> > my patches (since they're intrusive).
> 
> As Sarah is the maintainer of the file, I'll leave that decision up to
> her :)
> 
> And keeping a config option for debugging isn't a good idea.  The rest
> of the kernel has switched to using dynamic debugging, so that distros
> and others can easily get information without requiring a kernel rebuild
> (which we can't expect users to always be able to do.)  So I would not
> recommend this change.
> 
> thanks,
> 
> greg k-h

On Tue, Mar 16, 2010 at 02:48:45PM -0600, Alex Chiang wrote:
> Naming consistency with other USB HCDs.
> 
> Signed-off-by: Alex Chiang <achiang@...com>
> ---
> Refreshed against 2.6.34-rc1 and compile tested.
> 
> I didn't refresh the debug one; waiting to hear back from Sarah
> to see if it's worth doing or not.

Ok, I didn't see Greg's email about dynamic debugging.  I guess you
shouldn't refresh the second patch.  I'm not sure how I would go about
converting the xHCI driver to dynamic debugging, as I haven't looked
into it.  Is there any documentation/simple examples?

Greg, does the less-verbose patch with log levels still make sense if
the driver got converted over to dynamic debugging?

Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/