linux-kernel - Re: [PATCH 0/2] small xhci cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100316214014.GA8839@kroah.com>
Date:	Tue, 16 Mar 2010 14:40:14 -0700
From:	Greg KH <greg@...ah.com>
To:	Sarah Sharp <sarah.a.sharp@...ux.intel.com>
Cc:	Alex Chiang <achiang@...com>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] small xhci cleanups

On Tue, Mar 16, 2010 at 02:24:45PM -0700, Sarah Sharp wrote:
> Ok, I didn't see Greg's email about dynamic debugging.  I guess you
> shouldn't refresh the second patch.  I'm not sure how I would go about
> converting the xHCI driver to dynamic debugging, as I haven't looked
> into it.  Is there any documentation/simple examples?

Yes, just use 'dev_dbg' and you are finished.

Or pr_debug if you want to use different logging levels with your
macros.

> Greg, does the less-verbose patch with log levels still make sense if
> the driver got converted over to dynamic debugging?

I don't know what people really want to see.  In 6 months you will
probably only care about "debugging on or off" as the majority of the
messages only help you out when developing the driver, right?

So maybe par down some of the messages, or just live with seeing them
all, it will be easier in the end.

thanks,

grg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/