| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 16 Mar 2010 10:56:56 +0800 From: Shaohua Li <shaohua.li@...el.com> To: linux-kernel@...r.kernel.org Cc: jens.axboe@...cle.com, czoccolo@...il.com, vgoyal@...hat.com, jmoyer@...hat.com, guijianfeng@...fujitsu.com, alex.shi@...el.com, shaohua.li@...el.com Subject: [RFC]cfq-iosched: fix a kbuild regression Alex Shi reported a kbuild regression which is about 10% performance lost. He bisected to this commit: 3dde36ddea3e07dd025c4c1ba47edec91606fec0. The reason is cfqq_close() can't find close cooperator. If we store the seek distance to the value before the commit like below, the regression fully goes away. If this is too invasive, just changing the cfq_rq_close() for the !for_preempt is ok too. Reported-by: Alex Shi <alex.shi@...el.com> Signed-off-by: Shaohua Li <shaohua.li@...el.com> diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c index dee9d93..fcae456 100644 --- a/block/cfq-iosched.c +++ b/block/cfq-iosched.c @@ -46,7 +46,7 @@ static const int cfq_hist_divisor = 4; #define CFQ_HW_QUEUE_MIN (5) #define CFQ_SERVICE_SHIFT 12 -#define CFQQ_SEEK_THR (sector_t)(8 * 100) +#define CFQQ_SEEK_THR (sector_t)(8 * 1024) #define CFQQ_SECT_THR_NONROT (sector_t)(2 * 32) #define CFQQ_SEEKY(cfqq) (hweight32(cfqq->seek_history) > 32/8) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists