linux-kernel - Re: [RFC]cfq-iosched: fix a kbuild regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Mar 2010 19:24:10 +0100
From:	Corrado Zoccolo <czoccolo@...il.com>
To:	Jens Axboe <jens.axboe@...cle.com>
Cc:	Shaohua Li <shaohua.li@...el.com>, linux-kernel@...r.kernel.org,
	vgoyal@...hat.com, jmoyer@...hat.com, guijianfeng@...fujitsu.com,
	alex.shi@...el.com
Subject: Re: [RFC]cfq-iosched: fix a kbuild regression

On Wed, Mar 17, 2010 at 2:30 PM, Jens Axboe <jens.axboe@...cle.com> wrote:
> On Tue, Mar 16 2010, Shaohua Li wrote:
>> Alex Shi reported a kbuild regression which is about 10% performance lost.
>> He bisected to this commit: 3dde36ddea3e07dd025c4c1ba47edec91606fec0.
>> The reason is cfqq_close() can't find close cooperator. If we store the seek
>> distance to the value before the commit like below, the regression fully goes
>> away. If this is too invasive, just changing the cfq_rq_close() for the
>> !for_preempt is ok too.
>
> Corrado, any objections to widening the seek threshold?

The previous seek threshold value was meant to be compared with the
average seek distance, so it was large to account for variations.
Since we handle the variations differently, we should have a smaller
value now (the 100 * 8 was the result of a benchmark run on several
disks).
I agreee, though, that for merging queues, it is now too small, so we
should have two thresholds, the current one used to determine if a
request causes a seek, and an other to be used inside cfq_close (with
the older value, regardless of for_preempt).

Corrado

>
>>
>> Reported-by: Alex Shi <alex.shi@...el.com>
>> Signed-off-by: Shaohua Li <shaohua.li@...el.com>
>>
>> diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
>> index dee9d93..fcae456 100644
>> --- a/block/cfq-iosched.c
>> +++ b/block/cfq-iosched.c
>> @@ -46,7 +46,7 @@ static const int cfq_hist_divisor = 4;
>>  #define CFQ_HW_QUEUE_MIN     (5)
>>  #define CFQ_SERVICE_SHIFT       12
>>
>> -#define CFQQ_SEEK_THR                (sector_t)(8 * 100)
>> +#define CFQQ_SEEK_THR                (sector_t)(8 * 1024)
>>  #define CFQQ_SECT_THR_NONROT (sector_t)(2 * 32)
>>  #define CFQQ_SEEKY(cfqq)     (hweight32(cfqq->seek_history) > 32/8)
>>
>
> --
> Jens Axboe
>
>



-- 
__________________________________________________________________________

dott. Corrado Zoccolo                          mailto:czoccolo@...il.com
PhD - Department of Computer Science - University of Pisa, Italy
--------------------------------------------------------------------------
The self-confidence of a warrior is not the self-confidence of the average
man. The average man seeks certainty in the eyes of the onlooker and calls
that self-confidence. The warrior seeks impeccability in his own eyes and
calls that humbleness.
                               Tales of Power - C. Castaneda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/