linux-kernel - [PATCH 0/4] signal_struct->count must die, initial changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100317192847.GA2086@redhat.com>
Date:	Wed, 17 Mar 2010 20:28:47 +0100
From:	Oleg Nesterov <oleg@...hat.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Roland McGrath <roland@...hat.com>,
	Veaceslav Falico <vfalico@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: [PATCH 0/4] signal_struct->count must die, initial changes

signal_struct->count in its current form must die.

	- it has no reasons to be atomic_t

	- it looks like a reference counter, but it is not

	- otoh, we really need to make task->signal refcountable,
	  just look at the extremely ugly task_rq_unlock_wait()
	  called from __exit_signals().

	- we should change the lifetime rules for task->signal,
	  it should be pinned to task_struct. We have a lot of
	  code which can be simplified after that.

	- it is not needed! while the code is correct, any usage
	  of this counter is artificial, except fs/proc uses it
	  correctly to show the number of threads.

This series removes the usage of sig->count from exit pathes.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/