linux-kernel - [PATCH -mm 2/3] kill the obsolete thread_group_cputime_free() and taskstats_tgid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20100321184754.GA29075@redhat.com>
Date:	Sun, 21 Mar 2010 19:47:54 +0100
From:	Oleg Nesterov <oleg@...hat.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Balbir Singh <balbir@...ux.vnet.ibm.com>,
	Roland McGrath <roland@...hat.com>,
	Veaceslav Falico <vfalico@...hat.com>,
	Stanislaw Gruszka <sgruszka@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: [PATCH -mm 2/3] kill the obsolete thread_group_cputime_free() and
	taskstats_tgid_init() helpers

Trivial, but a separate patch for paranoid reasons.

- Kill the empty thread_group_cputime_free() helper. It was needed
  to free the per-cpu data which we no longer have.

- Kill taskstats_tgid_init(), unneeded since
  "copy_signal() cleanup: use zalloc and remove initializations"
  a56704ef6b0c5796c9ff38cc78aa232dfb9644d7

Signed-off-by: Oleg Nesterov <oleg@...hat.com>
---

 include/linux/sched.h          |    4 ----
 include/linux/taskstats_kern.h |    7 -------
 kernel/fork.c                  |    1 -
 3 files changed, 12 deletions(-)

--- 34-rc1/include/linux/sched.h~12_KILL_DEAD_HELPERS	2010-03-21 18:31:47.000000000 +0100
+++ 34-rc1/include/linux/sched.h	2010-03-21 18:35:01.000000000 +0100
@@ -2396,10 +2396,6 @@ static inline void thread_group_cputime_
 	sig->cputimer.running = 0;
 }
 
-static inline void thread_group_cputime_free(struct signal_struct *sig)
-{
-}
-
 /*
  * Reevaluate whether the task has signals pending delivery.
  * Wake the task if so.
--- 34-rc1/include/linux/taskstats_kern.h~12_KILL_DEAD_HELPERS	2010-03-21 18:31:47.000000000 +0100
+++ 34-rc1/include/linux/taskstats_kern.h	2010-03-21 18:35:01.000000000 +0100
@@ -14,11 +14,6 @@
 extern struct kmem_cache *taskstats_cache;
 extern struct mutex taskstats_exit_mutex;
 
-static inline void taskstats_tgid_init(struct signal_struct *sig)
-{
-	sig->stats = NULL;
-}
-
 static inline void taskstats_tgid_free(struct signal_struct *sig)
 {
 	if (sig->stats)
@@ -30,8 +25,6 @@ extern void taskstats_init_early(void);
 #else
 static inline void taskstats_exit(struct task_struct *tsk, int group_dead)
 {}
-static inline void taskstats_tgid_init(struct signal_struct *sig)
-{}
 static inline void taskstats_tgid_free(struct signal_struct *sig)
 {}
 static inline void taskstats_init_early(void)
--- 34-rc1/kernel/fork.c~12_KILL_DEAD_HELPERS	2010-03-21 18:34:02.000000000 +0100
+++ 34-rc1/kernel/fork.c	2010-03-21 18:35:01.000000000 +0100
@@ -160,7 +160,6 @@ EXPORT_SYMBOL(free_task);
 
 static inline void free_signal_struct(struct signal_struct *sig)
 {
-	thread_group_cputime_free(sig);
 	kmem_cache_free(signal_cachep, sig);
 }
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/