linux-kernel - Re: [PATCH] staging: winbond: sme

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100321202622.GJ1933@elf.ucw.cz>
Date:	Sun, 21 Mar 2010 21:26:22 +0100
From:	Pavel Machek <pavel@....cz>
To:	Pekka Enberg <penberg@...helsinki.fi>
Cc:	Lars Lindley <lindley@...ote.org>, gregkh@...e.de, greg@...ah.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: winbond: sme_api.h Coding style fixes.


> >> @@ -18,42 +12,42 @@
> >>  #include "localpara.h"
> >>
> >>  /****************** CONSTANT AND MACRO SECTION ******************************/
> >> -#define _INLINE      __inline
> >> +#define _INLINE                              __inline
> >
> > doing s/_INLINE/__inline/ on whole sources would be nice....
> 
> We probably can just get rid of most of the inlines in the driver
> code, I think.

Yes. I do not think this driver is performance-critical, and GCC can
probably outsmart us.

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/