lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <84144f021003211325m7ab3f65ej901c6ad93cab8c69@mail.gmail.com>
Date:	Sun, 21 Mar 2010 22:25:16 +0200
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Pavel Machek <pavel@....cz>
Cc:	Lars Lindley <lindley@...ote.org>, gregkh@...e.de, greg@...ah.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: winbond: sme_api.h Coding style fixes.

On Sun, Mar 21, 2010 at 10:12 PM, Pavel Machek <pavel@....cz> wrote:
> On Sun 2010-03-21 17:55:03, Lars Lindley wrote:
>> I fixed the things reported by checkpatch.pl except
>> one long line and a __inline.
>> I also removed commented away code and versioning comments.
>>
>> Signed-off-by: Lars Lindley <lindley@...ote.org>
>
> ACK.

Acked-by: Pekka Enberg <penberg@...helsinki.fi>

>> @@ -18,42 +12,42 @@
>>  #include "localpara.h"
>>
>>  /****************** CONSTANT AND MACRO SECTION ******************************/
>> -#define _INLINE      __inline
>> +#define _INLINE                              __inline
>
> doing s/_INLINE/__inline/ on whole sources would be nice....

We probably can just get rid of most of the inlines in the driver code, I think.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ