linux-kernel - Re: [PATCH] mm/nommu.c:Dynamic alloc/free percpu area for nommu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 22 Mar 2010 11:50:39 +0000
From:	David Howells <dhowells@...hat.com>
To:	graff.yang@...il.com
Cc:	dhowells@...hat.com, tj@...nel.org, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, uclinux-dist-devel@...ckfin.uclinux.org
Subject: Re: [PATCH] mm/nommu.c:Dynamic alloc/free percpu area for nommu

<graff.yang@...il.com> wrote:

> -	return virt_to_page(addr);
> +	return (struct page *)
> +			(virt_to_page(addr)->index) ? : virt_to_page(addr);

Can the extra conditional operator be made subject to CONFIG_SMP?

> -	return page_to_pfn(virt_to_page(addr));
> +	return page_to_pfn((struct page *)
> +			(virt_to_page(addr)->index) ? : virt_to_page(addr));

Ditto.

> +#ifdef CONFIG_SMP
> ...
> +#endif

Can this be put into a separate file?  There's rather a lot in mm/nommu.c
these days.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/