linux-kernel - Re: [PATCH] mm/nommu.c:Dynamic alloc/free percpu area for nommu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7d86d44a1003221933x50378b37oe9556e1f169ff15a@mail.gmail.com>
Date:	Tue, 23 Mar 2010 10:33:49 +0800
From:	graff yang <graff.yang@...il.com>
To:	David Howells <dhowells@...hat.com>
Cc:	tj@...nel.org, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, uclinux-dist-devel@...ckfin.uclinux.org
Subject: Re: [PATCH] mm/nommu.c:Dynamic alloc/free percpu area for nommu

On Mon, Mar 22, 2010 at 7:50 PM, David Howells <dhowells@...hat.com> wrote:
> <graff.yang@...il.com> wrote:
>
>> -     return virt_to_page(addr);
>> +     return (struct page *)
>> +                     (virt_to_page(addr)->index) ? : virt_to_page(addr);
>
> Can the extra conditional operator be made subject to CONFIG_SMP?

OK.
Tejun is looking into the up layer percpu code. So I expecting there
is better way
to hook nommu in.


>
>> -     return page_to_pfn(virt_to_page(addr));
>> +     return page_to_pfn((struct page *)
>> +                     (virt_to_page(addr)->index) ? : virt_to_page(addr));
>
> Ditto.
>
>> +#ifdef CONFIG_SMP
>> ...
>> +#endif
>
> Can this be put into a separate file?  There's rather a lot in mm/nommu.c
> these days.
>
> David
>



-- 
-Graff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/