linux-kernel - Re: [patch] afs: potential null dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28809.1269259520@redhat.com>
Date:	Mon, 22 Mar 2010 12:05:20 +0000
From:	David Howells <dhowells@...hat.com>
To:	Dan Carpenter <error27@...il.com>
Cc:	dhowells@...hat.com, kernel-janitors@...r.kernel.org,
	linux-afs@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [patch] afs: potential null dereference

Dan Carpenter <error27@...il.com> wrote:

> It seems clear from the surrounding code that xpermits is allowed to be 
> NULL here.

Interesting.  The memcpy() won't oops due to this because if it is given a
NULL pointer, it will also be given a zero count.  I wonder if this means the
if-statement your patch adds is actually unnecessary...

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/