linux-kernel - Re: [rfc][patch] mm, fs: warn on missing address space operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4BA75D20.2060905@panasas.com>
Date:	Mon, 22 Mar 2010 14:05:52 +0200
From:	Boaz Harrosh <bharrosh@...asas.com>
To:	Nick Piggin <npiggin@...e.de>
CC:	linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [rfc][patch] mm, fs: warn on missing address space operations

On 03/22/2010 12:54 PM, Nick Piggin wrote:
> On Mon, Mar 22, 2010 at 11:17:15AM +0200, Boaz Harrosh wrote:
>> ---
>> git diff --stat -p -M fs/exofs/inode.c
>>  fs/exofs/inode.c |    8 ++++++++
>>  1 files changed, 8 insertions(+), 0 deletions(-)
>>
>> diff --git a/fs/exofs/inode.c b/fs/exofs/inode.c
>> index a17e4b7..85dd847 100644
>> --- a/fs/exofs/inode.c
>> +++ b/fs/exofs/inode.c
>> @@ -754,6 +754,11 @@ static int exofs_write_end(struct file *file, struct address_space *mapping,
>>  	return ret;
>>  }
>>  
>> +static int exofs_releasepage(struct page *page, gfp_t gfp)
>> +{
>> +	return try_to_free_buffers(page);
>> +}
>> +
>>  const struct address_space_operations exofs_aops = {
>>  	.readpage	= exofs_readpage,
>>  	.readpages	= exofs_readpages,
>> @@ -761,6 +766,9 @@ const struct address_space_operations exofs_aops = {
>>  	.writepages	= exofs_writepages,
>>  	.write_begin	= exofs_write_begin_export,
>>  	.write_end	= exofs_write_end,
>> +	.releasepage	= exofs_releasepage,
>> +	.set_page_dirty	= __set_page_dirty_buffers,
>> +	.invalidatepage = block_invalidatepage,
>>  };
> 
> AFAIKS, you aren't using buffer heads at all (except nobh_truncate,
> which will not attach buffers to pages)?
> 
> If so, you should only need __set_page_dirty_nobuffers.
> 

Ho, thanks, that one is much better, yes.

BTW:
The use of nobh_truncate, I hope will go away after your:
	fs: truncate introduce new sequence
with these two helpers you added I can actually get rid of
that as well. (I think. I keep postponing this work ;-))

> Thanks,
> Nick
> 

Thanks
Boaz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/