linux-kernel - Re: [rt2x00-users] [PATCH RFC] rt2500usb: disable broken HW encryption by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a32f33a41003220840p7e3c3ba5j70d85950e4646b3c@mail.gmail.com>
Date:	Mon, 22 Mar 2010 16:40:57 +0100
From:	Ivo Van Doorn <ivdoorn@...il.com>
To:	Ondrej Zary <linux@...nbow-software.org>
Cc:	rt2x00 Users List <users@...x00.serialmonkey.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [rt2x00-users] [PATCH RFC] rt2500usb: disable broken HW 
	encryption by default

>> But I though it was mentioned that disabling HW crypto didn't solve
>> the issue due to a second bug in a later kernel?
>
> That was a false positive. Probably because the device was not unplugged
> between the tests (and looks like the driver does not initialize the chip completely).
> It's not reliable, it sometimes stops working after reboot.

Ah well that at least simplifies the problem. I'll have to retest rt2500usb soon
to see why the HW crypto failed. I am sure I had it working for WEP,
WPA and WPA2
before I submitted the patch.

> Since HW encryption was added to rt2500usb in 2.6.29, the driver does not
> work. It has been discussed before but never solved:
> http://rt2x00.serialmonkey.com/phpBB/viewtopic.php?f=4&t=4834
> https://bugzilla.redhat.com/show_bug.cgi?id=484888
>
> The problem is caused by this patch:
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=dddfb478b26e29a2b47f655ec219e743b8111015
>
> Disable HW encryption by default to fix it.
>
> Signed-off-by: Ondrej Zary <linux@...nbow-software.org>
>
> --- linux-2.6.34-rc2-orig/drivers/net/wireless/rt2x00/rt2500usb.c       2010-03-20 02:17:57.000000000 +0100
> +++ linux-2.6.34-rc2/drivers/net/wireless/rt2x00/rt2500usb.c    2010-03-22 16:16:55.000000000 +0100
> @@ -36,11 +36,11 @@
>  #include "rt2500usb.h"
>
>  /*
> - * Allow hardware encryption to be disabled.
> + * Allow hardware encryption to be enabled.
>  */
> -static int modparam_nohwcrypt = 0;
> +static int modparam_nohwcrypt = 1;
>  module_param_named(nohwcrypt, modparam_nohwcrypt, bool, S_IRUGO);
> -MODULE_PARM_DESC(nohwcrypt, "Disable hardware encryption.");
> +MODULE_PARM_DESC(nohwcrypt, "Hardware encryption disabled by default, use nohwcrypt=0 to enable.");

Actually could you just change the default value and nothing else?
The meaning of the module parameter doesn't change. So the Module
parameter description doesn't need to be updated as far as I am
concerned

Thanks,

Ivo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/