Message-Id: <201003231027.34095.linux@rainbow-software.org>
Date:	Tue, 23 Mar 2010 10:27:33 +0100
From:	Ondrej Zary <linux@...nbow-software.org>
To:	Ivo Van Doorn <ivdoorn@...il.com>
Cc:	rt2x00 Users List <users@...x00.serialmonkey.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [rt2x00-users] [PATCH RFC] rt2500usb: disable broken HW  encryption by default

On Monday 22 March 2010, Ivo Van Doorn wrote:
> >> But I though it was mentioned that disabling HW crypto didn't solve
> >> the issue due to a second bug in a later kernel?
> >
> > That was a false positive. Probably because the device was not unplugged
> > between the tests (and looks like the driver does not initialize the chip
> > completely). It's not reliable, it sometimes stops working after reboot.
>
> Ah well that at least simplifies the problem. I'll have to retest rt2500usb
> soon to see why the HW crypto failed. I am sure I had it working for WEP,
> WPA and WPA2
> before I submitted the patch.

So let's try to fix it instead of disabling.

First, the unrealiability (keeping HW encryption disabled). With the driver 
loaded but not doing anything more, the register dumps are same for both 
working and non-working case (dump-init.txt).

dump-good-connected.txt is a dump after successful association and DHCP
dump-bad-attempt.txt is a dump after successful association during non-working 
DHCP attempt
dump-bad-after.txt is a dump after DHCP timed out

Here are the differences:

--- dump-good-connected.txt	2010-03-23 10:21:02.000000000 +0100
+++ dump-bad-attempt.txt	2010-03-23 10:21:39.000000000 +0100
@@ -19,19 +19,19 @@
 2 :0x00001700
 3 :0x0000eb31
 4 :0x000031a5
-5 :0x00001a00
-6 :0x0000d992
-7 :0x00006e24
+5 :0x00000000
+6 :0x00000000
+7 :0x00000000
 8 :0x00000980
 9 :0x0000ff1d
-10 :0x00000009
+10 :0x00000014
 11 :0x0000000a
-12 :0x00000156
+12 :0x0000016c
 13 :0x00001111
 14 :0x00001e11
 15 :0x000001ee
 16 :0x00000000
-17 :0x000000aa
+17 :0x000000be
 18 :0x00008450
 19 :0x0000ff00
 20 :0x00000003
@@ -56,7 +56,7 @@
 39 :0x00008687
 40 :0x00000085
 41 :0x00000162
-42 :0x0000000e
+42 :0x0000000a
 43 :0x0000000f
 44 :0x0000140a
 45 :0x00007038
@@ -117,26 +117,26 @@
 100 :0x0000000f
 101 :0x00008204
 102 :0x0000821c
-103 :0x0000112a
+103 :0x00001126
 104 :0x00000000
-105 :0x00000e1b
+105 :0x00000e07
 106 :0x00005400
 107 :0x00000000
 108 :0x00000000
 109 :0x00000000
 110 :0x00000000
 111 :0x00000000
-112 :0x000004c0
-113 :0x0000883b
-114 :0x0000006f
-115 :0x00002c75
+112 :0x00000000
+113 :0x00000dd0
+114 :0x00000048
+115 :0x00000000
 116 :0x00000000
 117 :0x00000000
-118 :0x00000015
+118 :0x00000010
 119 :0x00000000
-120 :0x00000003
-121 :0x00000000
-122 :0x0000005d
+120 :0x00000000
+121 :0x00000001
+122 :0x00000000
 123 :0x00000000
 124 :0x00000000
 125 :0x00000000
@@ -200,13 +200,13 @@
 
 bbp
 0 :0x13
-1 :0xa2
+1 :0xab
 2 :0x04
 3 :0x02
 4 :0x19
 5 :0x0b
-6 :0x00
-7 :0x0e
+6 :0x10
+7 :0x00
 8 :0x00
 9 :0x00
 10 :0x00
@@ -227,7 +227,7 @@
 25 :0x50
 26 :0x08
 27 :0x23
-28 :0x22
+28 :0x18
 29 :0x00
 30 :0x10
 31 :0x2b
@@ -241,25 +241,25 @@
 39 :0xc4
 40 :0x02
 41 :0x60
-42 :0x09
-43 :0x33
-44 :0x22
-45 :0x2b
-46 :0xb4
+42 :0x0b
+43 :0x6f
+44 :0x29
+45 :0x36
+46 :0xa3
 47 :0x0a
 48 :0x04
-49 :0x04
-50 :0x90
+49 :0x00
+50 :0x70
 51 :0x26
-52 :0x04
+52 :0x02
 53 :0x10
 54 :0x18
-55 :0x17
+55 :0x2e
 56 :0x08
 57 :0x10
 58 :0x08
 59 :0x3e
-60 :0x03
+60 :0x02
 61 :0x66
 62 :0x00
 63 :0x00
@@ -286,7 +286,7 @@
 84 :0xc0
 85 :0x10
 86 :0xcf
-87 :0x05
+87 :0x00
 88 :0x00
 89 :0x00
 90 :0x00


-- 
Ondrej Zary

View attachment "dump-init.txt" of type "text/plain" (3672 bytes)

View attachment "dump-good-connected.txt" of type "text/plain" (3672 bytes)

View attachment "dump-bad-attempt.txt" of type "text/plain" (3672 bytes)

View attachment "dump-bad-after.txt" of type "text/plain" (3673 bytes)

Powered by blists - more mailing lists