linux-kernel - Re: [PATCH v3] KVM MMU: check reserved bits only if CR4.PSE=1 or CR4.PAE=1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100323153201.GA16878@amt.cnet>
Date:	Tue, 23 Mar 2010 12:32:01 -0300
From:	Marcelo Tosatti <mtosatti@...hat.com>
To:	Xiao Guangrong <xiaoguangrong@...fujitsu.com>
Cc:	Avi Kivity <avi@...hat.com>, Sheng Yang <sheng@...ux.intel.com>,
	LKML <linux-kernel@...r.kernel.org>,
	KVM list <kvm@...r.kernel.org>
Subject: Re: [PATCH v3] KVM MMU:  check reserved bits only  if CR4.PSE=1 or
 CR4.PAE=1

On Fri, Mar 19, 2010 at 05:58:53PM +0800, Xiao Guangrong wrote:
> - Check reserved bits only if CR4.PAE=1 or CR4.PSE=1 when guest #PF occurs
> - Fix a typo in reset_rsvds_bits_mask()
> 
> Signed-off-by: Xiao Guangrong <xiaoguangrong@...fujitsu.com>

Reviewed-by: Marcelo Tosatti <mtosatti@...hat.com>

> ---
>  arch/x86/kvm/mmu.c |   12 +++++++++---
>  1 files changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
> index b137515..d6c1f03 100644
> --- a/arch/x86/kvm/mmu.c
> +++ b/arch/x86/kvm/mmu.c
> @@ -2293,13 +2293,19 @@ static void reset_rsvds_bits_mask(struct kvm_vcpu *vcpu, int level)
>  		/* no rsvd bits for 2 level 4K page table entries */
>  		context->rsvd_bits_mask[0][1] = 0;
>  		context->rsvd_bits_mask[0][0] = 0;
> +		context->rsvd_bits_mask[1][0] = context->rsvd_bits_mask[0][0];
> +
> +		if (!is_pse(vcpu)) {
> +			context->rsvd_bits_mask[1][1] = 0;
> +			break;
> +		}
> +
>  		if (is_cpuid_PSE36())
>  			/* 36bits PSE 4MB page */
>  			context->rsvd_bits_mask[1][1] = rsvd_bits(17, 21);
>  		else
>  			/* 32 bits PSE 4MB page */
>  			context->rsvd_bits_mask[1][1] = rsvd_bits(13, 21);
> -		context->rsvd_bits_mask[1][0] = context->rsvd_bits_mask[1][0];
>  		break;
>  	case PT32E_ROOT_LEVEL:
>  		context->rsvd_bits_mask[0][2] =
> @@ -2312,7 +2318,7 @@ static void reset_rsvds_bits_mask(struct kvm_vcpu *vcpu, int level)
>  		context->rsvd_bits_mask[1][1] = exb_bit_rsvd |
>  			rsvd_bits(maxphyaddr, 62) |
>  			rsvd_bits(13, 20);		/* large page */
> -		context->rsvd_bits_mask[1][0] = context->rsvd_bits_mask[1][0];
> +		context->rsvd_bits_mask[1][0] = context->rsvd_bits_mask[0][0];
>  		break;
>  	case PT64_ROOT_LEVEL:
>  		context->rsvd_bits_mask[0][3] = exb_bit_rsvd |
> @@ -2330,7 +2336,7 @@ static void reset_rsvds_bits_mask(struct kvm_vcpu *vcpu, int level)
>  		context->rsvd_bits_mask[1][1] = exb_bit_rsvd |
>  			rsvd_bits(maxphyaddr, 51) |
>  			rsvd_bits(13, 20);		/* large page */
> -		context->rsvd_bits_mask[1][0] = context->rsvd_bits_mask[1][0];
> +		context->rsvd_bits_mask[1][0] = context->rsvd_bits_mask[0][0];
>  		break;
>  	}
>  }
> -- 
> 1.6.6.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/