linux-kernel - Re: [PATCH] Introduce freeze_super and thaw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4BA95BEB.7040805@crca.org.au>
Date:	Wed, 24 Mar 2010 11:25:15 +1100
From:	Nigel Cunningham <ncunningham@...a.org.au>
To:	Al Viro <viro@...IV.linux.org.uk>
CC:	Josef Bacik <josef@...hat.com>, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, chris.mason@...cle.com, hch@....de
Subject: Re: [PATCH] Introduce freeze_super and thaw_super for the fsfreeze
 ioctl

Hi.

On 24/03/10 11:21, Al Viro wrote:
> On Wed, Mar 24, 2010 at 10:55:45AM +1100, Nigel Cunningham wrote:
>> Hi again.
>>
>> On 24/03/10 10:52, Nigel Cunningham wrote:
>>>> I've stayed away from TuxOnIce flamefests and I've no idea how
>>>> representative
>>>> that snippet is, but if it *does* match the general code quality in
>>>> there...
>>>> Ouch.
>>>
>>> Locking isn't necessary because of the freezing.
>>
>> Err, freezer, I mean.
>
> Even leaving aside the accuracy of that (and I seriously doubt it), this
> is completely wrong since *code* *gets* *copied*.

Ok. That's a fair enough point. I'll add locking.

Regards,

Nigel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/