linux-kernel - Re: [PATCH] xfs: Fix integer overflow in fs/xfs/linux-2.6/xfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100324215436.GC7671@dastard>
Date:	Thu, 25 Mar 2010 08:54:36 +1100
From:	Dave Chinner <david@...morbit.com>
To:	wzt.wzt@...il.com
Cc:	linux-kernel@...r.kernel.org, xfs-masters@....sgi.com,
	aelder@....com
Subject: Re: [PATCH] xfs: Fix integer overflow in
 fs/xfs/linux-2.6/xfs_ioctl*.c

On Wed, Mar 17, 2010 at 11:19:47AM +0800, wzt.wzt@...il.com wrote:
> The am_hreq.opcount field in the xfs_attrmulti_by_handle() interface
> is not bounded correctly. The opcount is used to determine the size
> of the buffer required. The size is bounded, but can overflow and so
> the size checks may not be sufficient to catch invalid opcounts.
> Fix it by catching opcount values that would cause overflows before
> calculating the size.
> 
> Signed-off-by: Zhitong Wang <zhitong.wangzt@...baba-inc.com>

Looks good now. I'll queue it up with all the other pending changes
I have.

Cheers,

Dave.
-- 
Dave Chinner
david@...morbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/