[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20100325110031.GX30031@ZenIV.linux.org.uk>
Date: Thu, 25 Mar 2010 11:00:31 +0000
From: Al Viro <viro@...IV.linux.org.uk>
To: Benny Halevy <bhalevy@...asas.com>
Cc: Boaz Harrosh <bharrosh@...asas.com>,
linux-fsdevel <linux-fsdevel@...r.kernel.org>,
"J. Bruce Fields" <bfields@...i.umich.edu>,
pNFS Mailing List <pnfs@...ux-nfs.org>,
linux-kernel <linux-kernel@...r.kernel.org>,
Doug Nazar <nazard.lkml@...il.com>,
Trond Myklebust <Trond.Myklebust@...app.com>
Subject: Re: [pnfs] [GIT BISECT] first bad commit: 1f36f774 Switch !O_CREAT
case to use of do_last()
On Thu, Mar 25, 2010 at 12:56:40PM +0200, Benny Halevy wrote:
> - if (*want_dir && !path->dentry->d_inode->i_op->lookup)
> + if (*want_dir && !path->dentry->d_inode->i_op->lookup) {
> + WARN_ON(1);
> goto exit_dput;
> + }
> path_to_nameidata(path, nd);
> audit_inode(pathname, nd->path.dentry);
> goto ok;
>
> but it is NOT tripping for this scenario.
>
> (for some reason I saw it tripping when building the kernel over nfs
> but it's benign)
It's ENOTDIR, not EISDIR, anyway. Happens if you ask to open foo/ or
foo with O_DIRECTORY when foo is not a directory.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists