linux-kernel - Re: [pnfs] [GIT BISECT] first bad commit: 1f36f774 Switch !O_CREAT case to use of do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4BAB4523.1010601@panasas.com>
Date:	Thu, 25 Mar 2010 13:12:35 +0200
From:	Benny Halevy <bhalevy@...asas.com>
To:	Al Viro <viro@...IV.linux.org.uk>
CC:	Boaz Harrosh <bharrosh@...asas.com>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	"J. Bruce Fields" <bfields@...i.umich.edu>,
	pNFS Mailing List <pnfs@...ux-nfs.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Doug Nazar <nazard.lkml@...il.com>,
	Trond Myklebust <Trond.Myklebust@...app.com>
Subject: Re: [pnfs] [GIT BISECT] first bad commit: 1f36f774 Switch !O_CREAT
 case to use of do_last()

On Mar. 25, 2010, 13:00 +0200, Al Viro <viro@...IV.linux.org.uk> wrote:
> On Thu, Mar 25, 2010 at 12:56:40PM +0200, Benny Halevy wrote:
>> -		if (*want_dir && !path->dentry->d_inode->i_op->lookup)
>> +		if (*want_dir && !path->dentry->d_inode->i_op->lookup) {
>> +			WARN_ON(1);
>>  			goto exit_dput;
>> +		}
>>  		path_to_nameidata(path, nd);
>>  		audit_inode(pathname, nd->path.dentry);
>>  		goto ok;
>>
>> but it is NOT tripping for this scenario.
>>
>> (for some reason I saw it tripping when building the kernel over nfs
>> but it's benign)
> 
> It's ENOTDIR, not EISDIR, anyway.  Happens if you ask to open foo/ or
> foo with O_DIRECTORY when foo is not a directory.

Hmm, not according to my strace (or am I blind today? :)

> > open(".git/objects/pack", O_RDONLY|O_NONBLOCK|O_DIRECTORY|0x80000) = -1 EISDIR (Is a directory)

The odd thing is the app incorrectly gets EISDIR despite
the fact that it is opening a directory with O_DIRECTORY.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/