linux-kernel - Re: [PATCH] Prevent nested interrupts when the IRQ stack is near overflowing v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100325205124.GB27801@elte.hu>
Date:	Thu, 25 Mar 2010 21:51:24 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	David Miller <davem@...emloft.net>
Cc:	torvalds@...ux-foundation.org, peterz@...radead.org,
	tglx@...utronix.de, andi@...stfloor.org, x86@...nel.org,
	linux-kernel@...r.kernel.org, jesse.brandeburg@...el.com
Subject: Re: [PATCH] Prevent nested interrupts when the IRQ stack is near
 overflowing v2


* David Miller <davem@...emloft.net> wrote:

> From: Linus Torvalds <torvalds@...ux-foundation.org>
> Date: Thu, 25 Mar 2010 12:10:22 -0700 (PDT)
> 
> > On Thu, 25 Mar 2010, Ingo Molnar wrote:
> >> 
> >> So the patch below should at most trigger bugs in areas that need fixing 
> >> anyway, and i'm quite sure that under no circumstance would it cause 
> >> unforeseen problems in 'thousands of drivers'.
> > 
> > If we do this, then we should just remove all the IRQF_DISABLED code in 
> > kernel/irq/manage.c too, and basically make IRQF_DISABLED a clear no-op 
> > (still leave it around as a #define, to not break any users).
> 
> FWIW, I'm currently using IRQF_DISABLED for virtual network device 
> interrupts on sparc64 as a workaround for some stack overflow issues.

I think IRQF_DISABLED is the sanest method to run IRQs: it's the most atomic, 
thus most cache-efficient, it doesnt nest, and it's also a tiny bit faster to 
execute, by a few instructions (on x86).

> This change will just force me to work harder to find out a better way to 
> fix the problem, so don't let my issue hold this back, it's just an FYI...

The patch i sent basically hardcodes IRQF_DISABLED - so it should fix your 
problem automatically. IRQF_DISABLED will become an unconditional thing, and 
we can then also remove it.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/