linux-kernel - Re: [PATCH] Allow MACB to connect to a higher addresses PHY.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <x2gfa686aa41003302308r8c4f84acy5ab0c7368313aa5@mail.gmail.com>
Date:	Wed, 31 Mar 2010 00:08:28 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Anders Darander <anders.darander@...arespons.se>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Maxime Bizon <mbizon@...ebox.fr>,
	David Daney <ddaney@...iumnetworks.com>,
	Sekhar Nori <nsekhar@...com>,
	Anton Vorontsov <avorontsov@...mvista.com>,
	Andy Fleming <afleming@...escale.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Allow MACB to connect to a higher addresses PHY.

On Tue, Mar 30, 2010 at 11:53 PM, Anders Darander
<anders.darander@...arespons.se> wrote:
> * Grant Likely <grant.likely@...retlab.ca> [100330 16:42]:
> One question, if I add such an kernel parameter, would it be OK to
> implement something like this in the macb-driver:
>
> if parameter == SOME_DEFAULT
>        phydev = phy_find_first(bp->mii_bus);
> else
>        phydev = bp->mii_bus->phy_map[parameter];
>
> I.e. if the parameter is set to some default value, the old behaviour is
> retained, otherwise the specified parameter is used for the phy_addr?

Absolutely.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/