linux-kernel - Re: [PATCH] Arm nomadik : Vendor tool compatibility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 1 Apr 2010 01:34:24 +0200
From:	Linus Walleij <linus.ml.walleij@...il.com>
To:	Lemetayer Jean Marie <jeanmarie.lemetayer@...ran.com>
Cc:	linux@....linux.org.uk, dwmw2@...radead.org,
	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] Arm nomadik : Vendor tool compatibility

2010/3/31 Lemetayer Jean Marie <jeanmarie.lemetayer@...ran.com>:

> +#ifdef CONFIG_VENDOR_TOOL_COMPATIBILITY
> +static struct nand_ecclayout nomadik_ecc_layout = {
> +       .eccbytes = 3 * 4,
> +       .eccpos = {
> +               0x28, 0x29, 0x2A,
> +               0x2B, 0x2C, 0x2D,
> +               0x2E, 0x2F, 0x30,
> +               0x31, 0x32, 0x33},
> +       .oobfree = {{0x02, 0x26}, {0x34, 0x0C} },
> +};
> +#else
>  static struct nand_ecclayout nomadik_ecc_layout = {
>         .eccbytes = 3 * 4,
>         .eccpos = { /* each subpage has 16 bytes: pos 2,3,4 hosts ECC */
> @@ -54,6 +65,7 @@ static struct nand_ecclayout nomadik_ecc_layout = {
>         /* let's keep bytes 5,6,7 for us, just in case we change ECC algo */
>         .oobfree = { {0x08, 0x08}, {0x18, 0x08}, {0x28, 0x08}, {0x38, 0x08}
> },
>  };
> +#endif

Acked-by: Linus Walleij <linus.walleij@...ricsson.com>

I don't think any of this layout belongs in the driver itself frankly speaking,
I am facing the need to use this in U300 and we use yet *another*
ECC layout with the FSMC, so we have to add yet another #ifdef.
However I can fix that up with a patch on top of this one after it's
queued.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/