linux-kernel - Re: [patch] dma-debug: off by one issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100405140215.GA29758@8bytes.org>
Date:	Mon, 5 Apr 2010 16:02:15 +0200
From:	Joerg Roedel <joro@...tes.org>
To:	Dan Carpenter <error27@...il.com>,
	Joerg Roedel <joerg.roedel@....com>,
	Ingo Molnar <mingo@...e.hu>,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
	Shaun Ruffell <sruffell@...ium.com>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] dma-debug: off by one issue

On Mon, Apr 05, 2010 at 03:53:30PM +0300, Dan Carpenter wrote:
> On Sat, Apr 03, 2010 at 10:47:17PM +0200, Joerg Roedel wrote:

> > The character is already reserved by the user-to-kernel copy earlier in
> > the function.
> 
> Yes, but the original code requires more code reading to audit. Let's 
> change the commit message to say that it's a clean up patch.

In this case its better to remove the

	current_driver_name[i] = 0;

line just after the loop.

	Joerg

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/