linux-kernel - Re: [PATCH 23/24] video/matrox: fix dangling pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1004051504200.16108@casper.infradead.org>
Date:	Mon, 5 Apr 2010 15:04:43 +0100 (BST)
From:	James Simmons <jsimmons@...radead.org>
To:	Wolfram Sang <w.sang@...gutronix.de>
cc:	kernel-janitors@...r.kernel.org, linux-i2c@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Petr Vandrovec <vandrove@...cvut.cz>,
	Linux Fbdev development list <linux-fbdev@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH 23/24] video/matrox: fix dangling pointers


On Sat, 20 Mar 2010, Wolfram Sang wrote:

> Fix I2C-drivers which missed setting clientdata to NULL before freeing the
> structure it points to. Also fix drivers which do this _after_ the structure
> was freed already.
> 
> Signed-off-by: Wolfram Sang <w.sang@...gutronix.de>
> Cc: Petr Vandrovec <vandrove@...cvut.cz>
> ---

Acked-by: James Simmons <jsimmons@...radead.org>
 
> Found using coccinelle, then reviewed. Full patchset is available via
> kernel-janitors, linux-i2c, and LKML.
> ---
>  drivers/video/matrox/matroxfb_maven.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/video/matrox/matroxfb_maven.c b/drivers/video/matrox/matroxfb_maven.c
> index 91af915..e7b0ec3 100644
> --- a/drivers/video/matrox/matroxfb_maven.c
> +++ b/drivers/video/matrox/matroxfb_maven.c
> @@ -1254,6 +1254,7 @@ static int maven_probe(struct i2c_client *client,
>  		goto ERROR4;
>  	return 0;
>  ERROR4:;
> +	i2c_set_clientdata(client, NULL);
>  	kfree(data);
>  ERROR0:;
>  	return err;
> -- 
> 1.7.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/