linux-kernel - Re: [PATCH] power/ds2782: fix clientdata on removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100406165007.GA27648@oksana.dev.rtsoft.ru>
Date:	Tue, 6 Apr 2010 20:50:07 +0400
From:	Anton Vorontsov <cbouatmailru@...il.com>
To:	Wolfram Sang <w.sang@...gutronix.de>
Cc:	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	Ryan Mallon <ryan@...ewatersys.com>,
	Hans Verkuil <hverkuil@...all.nl>,
	Jean Delvare <khali@...ux-fr.org>
Subject: Re: [PATCH] power/ds2782: fix clientdata on removal

On Sun, Apr 04, 2010 at 04:13:36PM +0200, Wolfram Sang wrote:
> On Thu, Apr 01, 2010 at 02:40:21PM +0400, Anton Vorontsov wrote:
> > On Thu, Apr 01, 2010 at 12:27:44PM +0200, Wolfram Sang wrote:
> > > Probably due to a copy & paste bug, clientdata was set again to the data
> > > structure (which is freed immediately afterwards) when it should be
> > > NULLed. Just remove the calls as the i2c-core does this automatically
> > > now.
> > > 
> > > Signed-off-by: Wolfram Sang <w.sang@...gutronix.de>
> > > Cc: Ryan Mallon <ryan@...ewatersys.com>
> > > Cc: Hans Verkuil <hverkuil@...all.nl>
> > > Cc: Anton Vorontsov <cbouatmailru@...il.com>
> > > Cc: Jean Delvare <khali@...ux-fr.org>
> > > ---
> > >
> > > Anton: If it is okay with you, I think this should go via the I2C-tree to
> > > ensure it comes after the needed modification of the i2c-core.
> > 
> > Sure thing.
> > 
> > Acked-by: Anton Vorontsov <cbouatmailru@...il.com>
> 
> Sorry, I misunderstood Jean. Would be nice if you could pick it up. Sorry for
> the noise.

Applied.

Thanks!

-- 
Anton Vorontsov
email: cbouatmailru@...il.com
irc://irc.freenode.net/bd2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/