linux-kernel - Re: [PATCH v3] OMAP: Fix for bus width which improves SD card's peformance.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100406165720.GA17916@nokia.com>
Date:	Tue, 6 Apr 2010 19:57:20 +0300
From:	Felipe Balbi <felipe.balbi@...ia.com>
To:	ext Nishanth Menon <nm@...com>
Cc:	"Balbi Felipe (Nokia-D/Helsinki)" <felipe.balbi@...ia.com>,
	"Chikkature Rajashekar, Madhusudhan" <madhu.cr@...com>,
	"me@...ipebalbi.com" <me@...ipebalbi.com>,
	"'kishore kadiyala'" <kishorek.kadiyala@...il.com>,
	"'Vimal Singh'" <vimal.newwork@...il.com>,
	"tony@...mide.com" <tony@...mide.com>,
	"S, Venkatraman" <svenkatr@...com>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Lavinen Jarkko (Nokia-D/Helsinki)" <jarkko.lavinen@...ia.com>
Subject: Re: [PATCH v3] OMAP: Fix for bus width which improves SD card's
 peformance.

On Tue, Apr 06, 2010 at 06:55:03PM +0200, ext Nishanth Menon wrote:
>some reasons why i love switch statements ;) since I dont expect other
>than precisely 4 and 8 (do we expect 5,6,7 - i might be wrong).. but if
>it is so, wont the following be better?
>
>switch (mmc_slot(host).wires)
>{
>case 8:
>	mmc->caps |= MMC_CAP_8_BIT_DATA;
>	/* fall thru*/
>case 4:
>	mmc->caps |= MMC_CAP_4_BIT_DATA;
>		break;
>default:
>	WARN("bad width");
>}

I like that, but I remember Madhu (or someone else) saying he thinks 
it's less readable this way. Go figure...

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/