lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 9 Apr 2010 19:34:05 -0700 From: Divyesh Shah <dpshah@...gle.com> To: Vivek Goyal <vgoyal@...hat.com> Cc: jens.axboe@...cle.com, linux-kernel@...r.kernel.org, nauman@...gle.com, ctalbott@...gle.com Subject: Re: [PATCH 2/3] blkio: Add io_queued and avg_queue_size stats On Fri, Apr 9, 2010 at 8:32 AM, Vivek Goyal <vgoyal@...hat.com> wrote: >> +void blkiocg_update_request_add_stats(struct blkio_group *blkg, >> + struct blkio_group *curr_blkg, bool direction, >> + bool sync) >> +{ > > curr_blkg is redundant? Missed this comment in my earlier response. No, curr_blkg is not redundant since it is used for determining whether we should set group_wait_time or not. This argument should really have been added in the 3rd patch instead of this one. Unless you really want me to, I'd just let it be. -Divyesh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists