[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4BC09032.1060004@dcl.info.waseda.ac.jp>
Date: Sat, 10 Apr 2010 23:50:26 +0900
From: Hitoshi Mitake <mitake@....info.waseda.ac.jp>
To: Peter Zijlstra <peterz@...radead.org>
CC: mingo@...e.hu, linux-kernel@...r.kernel.org, h.mitake@...il.com,
Paul Mackerras <paulus@...ba.org>,
Arnaldo Carvalho de Melo <acme@...hat.com>,
Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCH] Add "nested" field to event of lock_release
On 04/10/10 22:59, Peter Zijlstra wrote:
> On Sat, 2010-04-10 at 19:41 +0900, Hitoshi Mitake wrote:
>> State machine of perf lock requires "nested" field of lock_release(),
>> so this patch adds it to event.
>>
>> Signed-off-by: Hitoshi Mitake<mitake@....info.waseda.ac.jp>
>> Cc: Peter Zijlstra<a.p.zijlstra@...llo.nl>
>> Cc: Paul Mackerras<paulus@...ba.org>
>> Cc: Arnaldo Carvalho de Melo<acme@...hat.com>
>> Cc: Frederic Weisbecker<fweisbec@...il.com>
>
> The nested flag only indicates if it could be nested, not if it was
> actually nested. So no, this doesn't make any sense at all.
>
> (in fact, pretty much every lock_release out there has nested=1)
>
Ah, sorry, I misunderstood.
When looked at rwlock_release(), I judged that nested is required,
because double or more read_lock() is allowed.
Thanks for your correction :)
Hitoshi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists